Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap entities_to_geometry in Python #3038
Wrap entities_to_geometry in Python #3038
Changes from 8 commits
68269b0
c658c71
1df37b5
d97c671
16b87b7
a3d768f
39d06a0
7fc889c
d3c79bf
ed1b096
61a9193
2a32139
9b7b6cc
fb4e972
0b20889
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean? (I know it straight from the C++ docs). @jorgensd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a flag only used by BEMPP (at least at its introduction) to ensure consistent orientation of each facet (to make all cell normals point outwards).
@mscroggs might be able to comment on the necessity of this at the current stage of BEMPP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It it's still needed it needs an explanation of what is required for a consistent orientation, i.e. document how we related the normal vector to a facet to the vertex ordering. And does it apply for all facet shapes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still used by Bempp-cl, so I'm keen to keep it for now. I think we've only tested it for triangle facets, and I'd be keen to work towards removing this once Bempp-rs can do coupling without needing this.