-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff format mk2 #3044
Ruff format mk2 #3044
Conversation
jhale
commented
Feb 7, 2024
- Format, still some line too long errors?
- Modify CI.
- Remove flake8 and isort from image.
- Format C++ part.
- Fix remaining check issues.
Removed periodic bc test file, no longer needed.
module_name = f"_petsc_cffi_{worker}" | ||
if MPI.COMM_WORLD.Get_rank() == 0: | ||
ffibuilder = cffi.FFI() | ||
ffibuilder.cdef("""typedef int... PetscInt; | ||
ffibuilder.cdef( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I reading this right: ruff also formatted the C code in the string, not only the python code around it?
That is not an issue here, but we may want to be aware of this when applying ruff format e.g. to ffcx, which I guess has more parts like this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general though, I think it is bad that ruff edits the contents of triple quotes.
Not really happy about the multi-line imports, formatting around the |