Make standalone function for interpolation over non-matching meshes #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t we can distinguish between a submesh with 0 cells and a nonmatching mesh with 0 cells on a process
jorgensd
added
bug
|
The logic behind interpolation looks too complicated and the code is hard to follow. I don't see why different cases, e.g. matching and non-matching meshes, are forced through the same interface. |
I've now split the interpolation of nonmatching meshes into a separate function. |
jorgensd
changed the title
garth-wells
requested changes
Apr 29, 2024
There was a problem hiding this comment.
I think there is more that can be done to simplify and improve the logic.
- In C++ the number of functions can probably be reduced.
- The non-matching interpolation data structure should be a
struct. - The Python interface still has a function that tries to do too much. Interpolation for non-matching meshes is advanced functionality so it it ok for the user to be responsible for some of the steps, i.e. let the user create the required data structure.
jorgensd
commented
Apr 29, 2024
Co-authored-by: Garth N. Wells <[email protected]>
jorgensd
commented
Apr 29, 2024
Co-authored-by: Garth N. Wells <[email protected]>
…erpolation-flag-2
…erpolation-flag-2
garth-wells
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3173.
Simplifies logic of interpolate.
API Change
Non-matching meshes interpolation now has its own interface:
interpolate_nonmatching_meshesin both C++ and Python.It also clarifies that interpolation of
dolfinx::fem::Expressionis not supported on non-matching meshes.