Support Python interface build and run without petsc4py #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
reviewed
Apr 26, 2024
| @@ -36,6 +36,7 @@ dependencies = [ | |||
| docs = ["markdown", "pyyaml", "sphinx", "sphinx_rtd_theme"] | |||
| lint = ["ruff"] | |||
| optional = ["numba"] | |||
| petsc4py = ["petsc4py"] | |||
There was a problem hiding this comment.
Maybe we could just call this petsc = ["petsc4py"] for short?
There was a problem hiding this comment.
petsc and petsc4py are different things.
jhale
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the Python interface to be built without petcc4py.
pyproject.tomldoesn't handle optional build requirements, so comments have been added to explain why petsc4py isn't listed as build dependency.As it stands, if the C++ interface is built with PETSc and petsc4py is found then petsc4py is enabled in the Python interface build. Otherwise petsc4py is not enabled in the build.
Resolves #2472