Permutation computation refactoring #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscroggs
reviewed
May 18, 2024
|
|
||
| // If min_v is 2 or 3, swap. Why? | ||
| if (min_v == 2 or min_v == 3) | ||
| min_v = 5 - min_v; |
There was a problem hiding this comment.
To answer the why: min_v wants to be the number of vertices anticlockwise away the minimum numbered vertex is. If the vertices were numbered:
3 -- 2
| |
0 -- 1
We wouldn't need to do the swap, but as we use the numbering:
2 -- 3
| |
0 -- 1
we therefore need the swap
There was a problem hiding this comment.
Thanks @mscroggs . Maybe you can add something in-line to document this.
|
Fixes issue #3208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalise face permutation computation to get ready for mixed topology meshes.