Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker simplify (phase 2) #3232

Merged
merged 4 commits into from
May 28, 2024
Merged

Docker simplify (phase 2) #3232

merged 4 commits into from
May 28, 2024

Conversation

garth-wells
Copy link
Member

Use a virtual env in the Dockerfile for installing dependencies. This is nicer than overwriting system Python packages when installing/updating. Will also allow advanced users to test Python package versions more freely.

@garth-wells garth-wells added the ci Continuous Integration label May 28, 2024
@garth-wells garth-wells changed the title Docker simplify phase 2 Docker simplify (phase 2) May 28, 2024
@garth-wells garth-wells added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@garth-wells garth-wells added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 9533112 May 28, 2024
37 checks passed
@garth-wells garth-wells deleted the docker-simplify branch May 28, 2024 21:43
@jorgensd
Copy link
Sponsor Member

I think this is a rather intrusive change, as all CIs must change from python3 to python for running code. Can't we use an alias so that we keep some backwards compatibility? I am not saying we should use venv, but is there a point of having another python3 in that environment, as it is bound to cause confusion.

All my CIs will now fail and need adjustment, and those that are customized to test against both stable and nightly can no longer be merged into a build matrix without extra arguments.

@garth-wells
Copy link
Member Author

Why would a change python3 -> python be required?

@jorgensd
Copy link
Sponsor Member

Why would a change python3 -> python be required?

I inferred that from the changes in the CI, where you have replaced python3 -m pip with pip and python3 with python. Please let me know if I am mistaken, or if there is another motivation for this change.

@francesco-ballarin
Copy link
Member

Will the script at https://github.com/FEniCS/dolfinx/blob/main/docker/dolfinx-real-mode (and similarly dolfinx-complex-mode) need adjustament?

I guess I am a bit confused of what having a venv will mean now for real vs complex build.

@garth-wells
Copy link
Member Author

Why would a change python3 -> python be required?

I inferred that from the changes in the CI, where you have replaced python3 -m pip with pip and python3 with python. Please let me know if I am mistaken, or if there is another motivation for this change.

There should be no change required.

python3 -m pip is visual noise when pip is enough.

@jorgensd
Copy link
Sponsor Member

jorgensd commented May 29, 2024

Why would a change python3 -> python be required?

I inferred that from the changes in the CI, where you have replaced python3 -m pip with pip and python3 with python. Please let me know if I am mistaken, or if there is another motivation for this change.

There should be no change required.

python3 -m pip is visual noise when pip is enough.

I dont necessarily agree, as by running pip you do not know what Python installation you are using.

Good to know that no changes are required. Is there a specific reason for the build docker and test Ci failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants