Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SCOTCH detection via CMake CONFIG mode. #3244

Merged
merged 5 commits into from
Jun 1, 2024
Merged

Conversation

garth-wells
Copy link
Member

@garth-wells garth-wells commented Jun 1, 2024

Search first for SCOTCH in CONFIG mode (look for a SCOTCH-provided config file), and if not found search using MODULE mode (using the DOLFINx provided FindSCOTCH.cmake).

@garth-wells garth-wells added the build Build system and compiler issues label Jun 1, 2024
@minrk
Copy link
Contributor

minrk commented Jun 1, 2024

Makes sense! I think the only case #3241 handles that this doesn't is SCOTCH_DIR having highest priority when find_package(SCOTCH CONFIG) succeeds and would produce a different result. I'm not sure that's worth handling, but seems worth mentioning. With this, I think there is no configuration or override available to fix things if SCOTCHConfig doesn't produce the right links.

@garth-wells garth-wells added this pull request to the merge queue Jun 1, 2024
Merged via the queue into main with commit 73238da Jun 1, 2024
28 checks passed
@garth-wells garth-wells deleted the garth/scotch-config branch June 1, 2024 14:18
@minrk
Copy link
Contributor

minrk commented Jun 1, 2024

Just to confirm, I updated the conda-forge Windows build with this PR and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system and compiler issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants