Replace multifunction with class methods for apply_restrictions #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
algorithms/apply_restrictions.pyto methods implemented on each class.*_legacyand added copies of these without the legacy that use class methods instead of multifunctions. (Short-to-medium term goal will be to move all other algorithms over to using the non-legacy functions then remove the legacy functions. This may be better done with multiple PRs rather than one huge PR for all algorithms)cutoffdecorator for class methods and make traversal function use this to check for cutoffs instead of requiring all types to have a typecode.I think this is a step in the right direction, but other opinions are welcome.