Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pullback of double derivatives on Piola type elements #312

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Fix pullback of double derivatives on Piola type elements #312

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
02cedcf
Add handling of case where a split returns a form with no arguments (…
jorgensd Oct 2, 2024
7a4ae70
Merge branch 'main' into dokken/form-split-no-arguments
jorgensd Oct 2, 2024
caedf44
Add test case
jorgensd Oct 2, 2024
98ab608
Add test and some error handling
jorgensd Oct 2, 2024
cd81e91
Apply restriction in formsplitter
jorgensd Oct 2, 2024
6623973
Fix docstring
jorgensd Oct 2, 2024
72948fc
Fix apply pullback on piola mapped elements for double derivatives
jorgensd Oct 7, 2024
3d9a527
Merge branch 'main' into dokken/fix-pullback-piola
jorgensd Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ufl/algorithms/apply_derivatives.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
Imag,
Indexed,
IndexSum,
Jacobian,
JacobianDeterminant,
JacobianInverse,
ListTensor,
Product,
Expand Down Expand Up @@ -672,7 +674,7 @@ def reference_grad(self, o):
f = o.ufl_operands[0]

valid_operand = f._ufl_is_in_reference_frame_ or isinstance(
f, (JacobianInverse, SpatialCoordinate)
f, (JacobianInverse, SpatialCoordinate, Jacobian, JacobianDeterminant)
)
if not valid_operand:
raise ValueError("ReferenceGrad can only wrap a reference frame type!")
Expand Down
Loading