Adjoint instead of transpose in tests #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up in a nanosoldier run related to JuliaLang/julia#46196. While `transpose(Q)` can be constructed, there exist no specialized (multiplication) methods for it. In your (test) case here, you are constructing a `Matrix` right away, which therefore probably falls back to componentwise `getindex`, which is slow, whereas `Matrix(Q')` uses fast specializations. My proposal is independent from the above-mentioned PR, and I'm pointing this out just in case this also occurs in code, not just in tests.
FHoltorf
approved these changes
Aug 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage 60.89% 60.89%
=======================================
Files 5 5
Lines 381 381
=======================================
Hits 232 232
Misses 149 149 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks for bringing that up. I was not aware and that will certainly be useful thing to know in the future. I will think the code base here looks fine. But I will doublecheck in a related package I built (github.com/FHoltorf/LowRankIntegrators.jl) as well. Thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in a nanosoldier run related to JuliaLang/julia#46196. While
transpose(Q)can be constructed, there exist no specialized (multiplication) methods for it. In your (test) case here, you are constructing aMatrixright away, which therefore probably falls back to componentwisegetindex, which is slow, whereasMatrix(Q')uses fast specializations.My proposal is independent from the above-mentioned PR, and I'm pointing this out just in case this also occurs in code, not just in tests.