ObjectExplorer: Add a new Shortcut for UIWindow to change animations speed #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make this just a shortcut on UIWindow for the time being without modifying the view shortcuts file? One of them doesn't even work for UIWindow so we don't lose that much, right? |
…eed" to its own FLEXWindowShortcuts class
|
You're right, I did not noticed "Nearest VC" wasn't working on UIWindows. |
|
Ugh, just clicked the wrong button while sending my comment, which closed the PR. Reopening. |
Classes/ObjectExplorers/Sections/Shortcuts/FLEXWindowShortcuts.m
Outdated
Show resolved
Hide resolved
Classes/ObjectExplorers/Sections/Shortcuts/FLEXWindowShortcuts.m
Outdated
Show resolved
Hide resolved
Classes/ObjectExplorers/Sections/Shortcuts/FLEXWindowShortcuts.m
Outdated
Show resolved
Hide resolved
|
Thanks! |
timonus
pushed a commit
to timonus/FLEX
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Shortcut to UIWindow to change its animations speed. It basically replicates the "Slow Animations" feature, only available on the Simulator. The user can set the speed of his choice.
As explained in the comments, as of now I've added it to UIView Shortcuts class instead of creating a new one for UIWindow. This is done like this to prevent UIWindow Shortcuts to override UIView ones (since as of now, an object can only get the Shortcuts from one class). Having a separate UIWindow class would have imply duplicating current UIView Shortcuts, which is not desirable. Tell me if you'd prefer any other way of handling this situation.