Address a few more minor comments reported by CI

FMCorz · Apr 23, 2024 · bbc2016 · bbc2016
1 parent bdaf45d
commit bbc2016
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -125,7 +125,7 @@ jobs:
 
       - name: Moodle Code Checker
         if: ${{ !cancelled() }}
-        run: moodle-plugin-ci phpcs --max-warnings 0
+        run: moodle-plugin-ci phpcs --max-warnings 0 --exclude moodle.Commenting.MissingDocblock
 
       # - name: Moodle PHPDoc Checker
       #   if: ${{ !cancelled() }}

diff --git a/classes/local/setting/compatibility_check_setting.php b/classes/local/setting/compatibility_check_setting.php
@@ -59,7 +59,7 @@ protected function get_html_content() {
 
         $blockxp = $pluginman->get_plugin_info('block_xp');
         $localxp = $pluginman->get_plugin_info('local_xp');
-        $recentishlocalxp = 2023100800; // v1.15.0.
+        $recentishlocalxp = 2023100800; // Version 1.15.0.
         $humanbranch = moodle_major_version() ?: 'v?';
 
         if ($localxp && $localxp->versiondb < $recentishlocalxp) {

diff --git a/classes/local/xp/algo_levels_info.php b/classes/local/xp/algo_levels_info.php
@@ -73,10 +73,7 @@ class algo_levels_info implements levels_info, levels_info_with_algo {
     /** @var array The metadata keys. */
     protected $metadatakeys = [];
 
-    /**
-     * @var bool Used algo?
-     * @deprecated Since Level Up XP 3.15 without replacement.
-     */
+    /** @var bool Used algo? Deprecated since Level Up XP 3.15 without replacement. */
     protected $usealgo = false;
 
     /**

diff --git a/tests/php_test.php b/tests/php_test.php
@@ -26,6 +26,7 @@
 namespace block_xp;
 
 use block_xp\tests\base_testcase;
+use Generator;
 
 defined('MOODLE_INTERNAL') || die();
 
@@ -46,7 +47,7 @@ final class php_test extends base_testcase {
      *
      * @return array
      */
-    public static function php_files_provider() {
+    public static function php_files_provider(): Generator {
         global $CFG;
 
         $xproot = $CFG->dirroot . '/blocks/xp';
@@ -80,7 +81,7 @@ public static function php_files_provider() {
      * @dataProvider php_files_provider
      * @covers \block_xp\di
      */
-    public function test_file_inclusion($relpath) {
+    public function test_file_inclusion($relpath): void {
         global $CFG, $DB;
         try {
             require_once($CFG->dirroot . '/blocks/xp' . $relpath);