Ts tips #368
Ts tips #368
Conversation
| @@ -466,7 +467,7 @@ uint32_t cylindersCount;Number of cylinder the engine has.;"", 1, 0, 1, @@MAX_CY | |||
| ! FO_1_2_4_5_3 = 6 | |||
|
|
|||
| custom firing_order_e 1 bits, U08, @OFFSET@, [0:5], "One Cylinder", "1-3-4-2", "1-2-4-3", "1-3-2-4", "1-5-3-6-2-4", "1-8-4-3-6-5-7-2", "1-2-4-5-3", "1-4-2-5-3-6", "1-2", "1-2-3-4-5-6", "1-2-3", "1-8-7-2-6-5-4-3", "1-5-4-2-6-3-7-8", "1-6-3-2-5-4", "1-10-9-4-3-6-5-8-7_2", "1-7-5-11-3-9-6-12-2-8-4-10", "1-7-4-10-2-8-6-12-3-9-5-11", "1-4-3-2", "1-12-5-8-3-10-6-7-2-11-4-9", "1-2-7-8-4-5-6-3", "1-3-7-2-6-5-4-8", "1-2-3-4-5-6-7-8-9", "INVALID", "1-2-3-4-5-6-7-8-9-10-11-12", "1-3-2", "1-2-3-4-5-6-7-8", "1-5-4-8-6-3-7-2", "1-4-3-6-2-5", "1-8-7-3-6-5-4-2", "1-6-2-4-3-5", "1-6-5-4-3-2", "1-4-5-2-3-6", "fo32", "fo33", "fo34", "fo35", "fo36", "fo37" | |||
| firing_order_e firingOrder; | |||
| firing_order_e firingOrder;Firing order of the engine; | |||
There was a problem hiding this comment.
do we really need a tooltip that says the same thing as the label? There are a few of these.
There was a problem hiding this comment.
Just trying to get to a stage where every item has a tool tip of some kind.
Then expand those tool tips a bit once everything has at least a minimum of info.
I'm with you, how new do you have to be to need a tip saying "firing order = firing order" but there is always a bigger idiot.
Round 2 of improvements maybe an expansion of that tip with a link to common firing orders on the wiki etc
|
Is there a possibility that adding too much additional text bloats the .ini to a size that won't fit on the STM's partition? |
Not really, it gets compressed, and English text compresses pretty well. |
|
If there's no big issues obvious on this then I will make config with it tomorrow and if all seems ok then PR it in so I can start on the next set. |
Putting in a draft PR so we can review progress so far.