idle stepper TS panel disable should not depend ETB functions #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rusefi/rusefi#5972 seems to be this issue; via: https://rusefi.com/forum/viewtopic.php?p=49196#p49196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems rusefi/rusefi#4904 may have been merged without thorough review
does this change make sense? configuring idle stepper hardware should not depend on ETB function/configuration, right?
rusEFI has the same logic yet: https://github.com/rusefi/rusefi/blob/master/firmware/tunerstudio/tunerstudio.template.ini#L3570 -- cc @rusefillc
also, perhaps still an issue exists if both ETB and idle stepper are trying to use the same hardware?
perhaps instead of this change, simply the condition should change from
!=to==, and possibly moved to a higher order?last, mind this comment? is this still applicable now that h-bridge panels are split w/ rusefi/rusefi#4904?