Praveen dev

[Praveen660100]

Add a debug in ospf_route_delete() to print information related to the route entry/entries that are deleted #23

[Praveen660100]

#23ospf_route_delete

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2294/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 4: No useful log found

Successful on other platforms/tests

• Topotests Ubuntu 18.04 amd64 part 2
• Addresssanitizer topotests part 5
• Addresssanitizer topotests part 4
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 i386 part 8
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 3
• IPv6 protocols on Ubuntu 18.04
• Topotests debian 10 amd64 part 8
• Topotests debian 10 amd64 part 4
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests Ubuntu 18.04 arm8 part 9
• Topotests Ubuntu 18.04 arm8 part 3
• Addresssanitizer topotests part 1
• Topotests debian 10 amd64 part 9
• IPv4 protocols on Ubuntu 18.04
• Topotests Ubuntu 18.04 arm8 part 7
• Static analyzer (clang)
• Addresssanitizer topotests part 9
• Topotests debian 10 amd64 part 0
• Topotests Ubuntu 18.04 amd64 part 9
• Topotests Ubuntu 18.04 arm8 part 0
• IPv4 ldp protocol on Ubuntu 18.04
• Topotests Ubuntu 18.04 arm8 part 2
• Ubuntu 16.04 deb pkg check
• Topotests debian 10 amd64 part 2
• Topotests Ubuntu 18.04 amd64 part 8
• Debian 10 deb pkg check
• Topotests Ubuntu 18.04 arm8 part 5
• Addresssanitizer topotests part 7
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 amd64 part 5
• Ubuntu 20.04 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 7
• Topotests debian 10 amd64 part 6
• Topotests debian 10 amd64 part 1
• Addresssanitizer topotests part 3
• Fedora 29 rpm pkg check
• Topotests Ubuntu 18.04 i386 part 5
• Topotests Ubuntu 18.04 i386 part 0
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 amd64 part 4
• Topotests Ubuntu 18.04 amd64 part 0
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 i386 part 9
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests debian 10 amd64 part 7
• Debian 9 deb pkg check
• Topotests debian 10 amd64 part 5
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 8
• Topotests Ubuntu 18.04 arm8 part 6
• Ubuntu 18.04 deb pkg check
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 arm8 part 1
• Addresssanitizer topotests part 6

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 4: No useful log found

<stdin>:14: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for ospf_route.c | 14 issues
===============================================
< ERROR: space required before the open brace '{'
< #109: FILE: /tmp/f1-27927/ospf_route.c:109:
< WARNING: line over 80 characters
< #110: FILE: /tmp/f1-27927/ospf_route.c:110:
< ERROR: space required after that ',' (ctx:VxV)
< #110: FILE: /tmp/f1-27927/ospf_route.c:110:
< ERROR: space required before the open brace '{'
< #114: FILE: /tmp/f1-27927/ospf_route.c:114:
< ERROR: else should follow close brace '}'
< #114: FILE: /tmp/f1-27927/ospf_route.c:114:
< WARNING: line over 80 characters
< #115: FILE: /tmp/f1-27927/ospf_route.c:115:
< ERROR: space required after that ',' (ctx:VxV)
< #115: FILE: /tmp/f1-27927/ospf_route.c:115:

[mjstapp]

So there are several issues here:

1. the description does not reflect the changes being offered, and seems to point at an unrelated issue
2. there's a random README-GROUP_3 file you're trying to add
3. you're trying to add unprotected debugs, that's not permitted
4. you seem to be trying to change help strings that have been around for a long time without any motivation
5. the commits are not correct - no merge commits please, each separate change in its own commit, fixes/corrections included by rebase rather than added commit

[donaldsharp]

commit messages must follow our format laid out in workflow.rst. Until then this is a nack as well from me

[idryzhov]

Is this something you really want to be merged or you're just using this PR to track/test some internal changes?

[qlyoung]

No response