Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Fix for session reset issue caused by malformed core attributes in update message (backport #14129) #14132

Merged
merged 1 commit into from
Aug 3, 2023
Merged

bgpd: Fix for session reset issue caused by malformed core attributes in update message (backport #14129) #14132

merged 1 commit into from
Aug 3, 2023

Commits on Aug 2, 2023

  1. bgpd: Fix session reset issue caused by malformed core attributes 

    RCA:
On encountering any attribute error for core attributes in update message,
the error handling is set to 'treat as withdraw' and
further parsing of the remaining attributes is skipped.
But the stream pointer is not being correctly adjusted to
point to the next NLRI field skipping the rest of the attributes.
This leads to incorrect parsing of the NLRI field,
which causes BGP session to reset.

Fix:
The stream pointer offset is rightly adjusted to point to the NLRI field correctly
when the malformed attribute is encountered and remaining attribute parsing is skipped.

Signed-off-by: Samanvitha B Bhargav <[email protected]>
(cherry picked from commit 70ff940)
    @samanvithab @mergify
    samanvithab authored and mergify[bot] committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    638b055 View commit details
    Browse the repository at this point in the history