pimd: Prevent crash when receiving register message when the RP() is … #14294

donaldsharp · 2023-08-29T19:01:13Z

…unknown

When receiving a register message for a Group, that the group has no associated RP specified. Prevent a crash from happening.

ton31337

LGTM

NetDEF-CI · 2023-08-29T19:29:46Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13870/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13870/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13870/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
pimd/pim_register.c: In function pim_register_recv:
./lib/zlog.h:109:20: error: unrecognized printf extension suffix [-Werror=format=]
./lib/zlog.h:113:26: note: in expansion of macro _zlog_ecref
pimd/pim_register.c:608:3: note: in expansion of macro zlog_warn
cc1: all warnings being treated as errors
make[1]: *** [Makefile:13314: pimd/pimd-pim_register.o] Error 1
In file included from ./lib/log.h:17,
pimd/pim_register.c: In function pim_register_recv:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13870/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests

Ubuntu 18.04 arm7 build
FreeBSD 11 amd64 build
CentOS 7 amd64 build
Ubuntu 18.04 amd64 build
Redhat 9 amd64 build
OpenBSD 7 amd64 build
FreeBSD 12 amd64 build
Redhat 8 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 20.04 amd64 build
Ubuntu 22.04 amd64 build
Debian 9 amd64 build
Ubuntu 18.04 arm8 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build

ton31337 · 2023-08-29T19:31:05Z

pimd/pim_register.c

-	rp_addr = (RP(pim, sg.grp))->rpf_addr;
+	rpg = RP(pim, sg.grp);
+	if (!rpg) {
+		zlog_warn("%s: Received Register Message %pSG from %pPa on %s where the RP could not be looked up",


Ups, %pPA

I am not sure what you are asking for here? Could you explain?

a small typo: %pPa, but should be %pPA?

NetDEF-CI · 2023-08-30T12:55:22Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13870/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13870/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13870/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
pimd/pim_register.c: In function pim_register_recv:
./lib/zlog.h:109:20: error: unrecognized printf extension suffix [-Werror=format=]
./lib/zlog.h:113:26: note: in expansion of macro _zlog_ecref
pimd/pim_register.c:608:3: note: in expansion of macro zlog_warn
cc1: all warnings being treated as errors
make[1]: *** [Makefile:13314: pimd/pimd-pim_register.o] Error 1
In file included from ./lib/log.h:17,
pimd/pim_register.c: In function pim_register_recv:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-13870/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests

Ubuntu 18.04 arm7 build
FreeBSD 11 amd64 build
CentOS 7 amd64 build
Ubuntu 18.04 amd64 build
Redhat 9 amd64 build
OpenBSD 7 amd64 build
FreeBSD 12 amd64 build
Redhat 8 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 20.04 amd64 build
Ubuntu 22.04 amd64 build
Debian 9 amd64 build
Ubuntu 18.04 arm8 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build

donaldsharp · 2023-08-30T15:04:19Z

@Mergifyio backport stable/9.0 stable/8.5

mergify · 2023-08-30T15:05:22Z

backport stable/9.0 stable/8.5

✅ Backports have been created

#14336 pimd: Prevent crash when receiving register message when the RP() is … (backport #14294) has been created for branch stable/9.0
#14338 pimd: Prevent crash when receiving register message when the RP() is … (backport #14294) has been created for branch stable/8.5

…unknown When receiving a register message for a Group, that the group has no associated RP specified. Prevent a crash from happening. Signed-off-by: Donald Sharp <[email protected]>

NetDEF-CI · 2023-08-31T14:31:36Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13913/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 amd64 part 9: Incomplete

(check logs for details)

Addresssanitizer topotests part 6: Failed (click for details)

## Error: SEGV

### AddressSanitizer error in topotest `common_config.py`, test `check_router_status`, router `r4`

    ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x55b4fbda2095 bp 0x7ffcba8d9af0 sp 0x7ffcba8d99a0 T0)
    ==31654==The signal is caused by a READ memory access.
    ==31654==Hint: address points to the zero page.
        #0 0x55b4fbda2094 in bgp_establish bgpd/bgp_fsm.c:2156
        #1 0x55b4fbda64e8 in bgp_event_update bgpd/bgp_fsm.c:2655
        #2 0x55b4fbdfb277 in bgp_process_packet bgpd/bgp_packet.c:3133
        #3 0x7f7a3e735b89 in event_call lib/event.c:1979
        #4 0x7f7a3e67a368 in frr_run lib/libfrr.c:1213
        #5 0x55b4fbcf37d1 in main bgpd/bgp_main.c:510
        #6 0x7f7a3d6bdc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #7 0x55b4fbcf1979 in _start (/usr/lib/frr/bgpd+0x2ce979)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV bgpd/bgp_fsm.c:2156 in bgp_establish

---------------
## Error: SEGV

### AddressSanitizer error in topotest `test_bgp_unique_rid.py`, test `teardown_module`, router `r4`

    ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x55b4fbda2095 bp 0x7ffcba8d9af0 sp 0x7ffcba8d99a0 T0)
    ==31654==The signal is caused by a READ memory access.
    ==31654==Hint: address points to the zero page.
        #0 0x55b4fbda2094 in bgp_establish bgpd/bgp_fsm.c:2156
        #1 0x55b4fbda64e8 in bgp_event_update bgpd/bgp_fsm.c:2655
        #2 0x55b4fbdfb277 in bgp_process_packet bgpd/bgp_packet.c:3133
        #3 0x7f7a3e735b89 in event_call lib/event.c:1979
        #4 0x7f7a3e67a368 in frr_run lib/libfrr.c:1213
        #5 0x55b4fbcf37d1 in main bgpd/bgp_main.c:510
        #6 0x7f7a3d6bdc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #7 0x55b4fbcf1979 in _start (/usr/lib/frr/bgpd+0x2ce979)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV bgpd/bgp_fsm.c:2156 in bgp_establish

---------------

Addresssanitizer topotests part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13913/artifact/ASAN6/Topotest-Details/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN6-13913/test

Topology Tests failed for Addresssanitizer topotests part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13913/artifact/ASAN6/TopotestLogs/log_topotests.txt

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 8
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 0
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 2
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4

NetDEF-CI · 2023-08-31T17:16:53Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13913/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 14294, comparing to Git base SHA c4f761d

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-13913/artifact/shared/static_analysis/index.html

pimd: Prevent crash when receiving register message when the RP() is … (backport #14294)

github-actions bot added size/S master labels Aug 29, 2023

frrbot bot added the pim label Aug 29, 2023

ton31337 approved these changes Aug 29, 2023

View reviewed changes

ton31337 reviewed Aug 29, 2023

View reviewed changes

github-actions bot added the backport label Aug 30, 2023

pimd: Prevent crash when receiving register message when the RP() is …

54aa0bf

…unknown When receiving a register message for a Group, that the group has no associated RP specified. Prevent a crash from happening. Signed-off-by: Donald Sharp <[email protected]>

donaldsharp force-pushed the pim_crashola branch from b082d76 to 54aa0bf Compare August 31, 2023 11:45

ton31337 merged commit 640b59a into FRRouting:master Sep 1, 2023
6 checks passed

This was referenced Sep 1, 2023

pimd: Prevent crash when receiving register message when the RP() is … (backport #14294) #14336

Merged

pimd: Prevent crash when receiving register message when the RP() is … (backport #14294) #14338

Merged

Jafaral added a commit that referenced this pull request Sep 2, 2023

Merge pull request #14336 from FRRouting/mergify/bp/stable/9.0/pr-14294

6674e08

pimd: Prevent crash when receiving register message when the RP() is … (backport #14294)

Jafaral added a commit that referenced this pull request Sep 2, 2023

Merge pull request #14338 from FRRouting/mergify/bp/stable/8.5/pr-14294

b798bfe

pimd: Prevent crash when receiving register message when the RP() is … (backport #14294)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pimd: Prevent crash when receiving register message when the RP() is … #14294

pimd: Prevent crash when receiving register message when the RP() is … #14294

donaldsharp commented Aug 29, 2023

ton31337 left a comment

NetDEF-CI commented Aug 29, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

ton31337 Aug 29, 2023

donaldsharp Aug 30, 2023

ton31337 Aug 30, 2023

NetDEF-CI commented Aug 30, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

donaldsharp commented Aug 30, 2023

mergify bot commented Aug 30, 2023 •

edited

Loading

NetDEF-CI commented Aug 31, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Aug 31, 2023

pimd: Prevent crash when receiving register message when the RP() is … #14294

pimd: Prevent crash when receiving register message when the RP() is … #14294

Conversation

donaldsharp commented Aug 29, 2023

ton31337 left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Aug 29, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

ton31337 Aug 29, 2023

Choose a reason for hiding this comment

donaldsharp Aug 30, 2023

Choose a reason for hiding this comment

ton31337 Aug 30, 2023

Choose a reason for hiding this comment

NetDEF-CI commented Aug 30, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

donaldsharp commented Aug 30, 2023

mergify bot commented Aug 30, 2023 • edited Loading

✅ Backports have been created

NetDEF-CI commented Aug 31, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Aug 31, 2023

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

NetDEF-CI commented Aug 29, 2023 •

edited

Loading

NetDEF-CI commented Aug 30, 2023 •

edited

Loading

mergify bot commented Aug 30, 2023 •

edited

Loading

NetDEF-CI commented Aug 31, 2023 •

edited

Loading