bgpd: add memberCount into peer-grp json output #16950
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member count is not part of current show bgp peer-group json output.
Fix:
memberCount attribute is added into bgp peer-grp json output.
Supported commands:
- show bgp peer-group json
- show bgp vrf tenant1 peer-group json
Ticket:#4073454
Testing:
tor-11# show bgp peer-group json
{
"ISL":{
"remoteAs":0,
"type":"external",
"addressFamiliesConfigured":[
"IPv4 Unicast"
],
"members":{
"swp1":{
"status":"Established"
},
"swp2":{
"status":"Established"
},
"memberCount":2
}
}
}
Signed-off-by: Sindhu Parvathi Gopinathan's <[email protected]>
mjstapp
reviewed
Sep 30, 2024
| } | ||
| if (json) | ||
| if (json) { | ||
| json_object_int_add(json_peer_group_members, |
There was a problem hiding this comment.
this seems similar to the other recent json change proposal - to add a new object that's ... not like the existing objects in the collection.
|
Adding my reason why we need this change. This commit is required since we don't want to consumer of this JSON to count again on the dictionary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Member count is not part of current show bgp peer-group json output.
Fix:
memberCount attribute is added into bgp peer-grp json output.
Supported commands:
Testing:
Signed-off-by: Sindhu Parvathi Gopinathan's [email protected]