-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: bmp loc-rib peer up/down for vrfs #17001
Open
louis-6wind
wants to merge
6
commits into
FRRouting:master
Choose a base branch
from
louis-6wind:bmp-new
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8b87f50
topotests: check export labels to pre-policy bmp
louis-6wind 6874327
bgpd: bmp loc-rib peer up/down for vrfs
mxyns 7321c2e
topotests: log bmp peer up message type in collector
louis-6wind 4d67fee
topotests: add peer down log in bmp collector
louis-6wind 4872db5
topotests: check for bmp peer up/down messages
louis-6wind fa8524a
topotest: add bgp_bmp_vrf topotest
louis-6wind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
router bgp 65501 vrf vrf1 | ||
bgp router-id 192.168.0.1 | ||
bgp log-neighbor-changes | ||
no bgp ebgp-requires-policy | ||
neighbor 192.168.0.2 remote-as 65502 | ||
neighbor 192:168::2 remote-as 65502 | ||
! | ||
bmp targets bmp1 | ||
bmp connect 192.0.2.10 port 1789 min-retry 100 max-retry 10000 | ||
exit | ||
! | ||
|
||
address-family ipv4 unicast | ||
neighbor 192.168.0.2 activate | ||
neighbor 192.168.0.2 soft-reconfiguration inbound | ||
no neighbor 192:168::2 activate | ||
exit-address-family | ||
! | ||
address-family ipv6 unicast | ||
neighbor 192:168::2 activate | ||
neighbor 192:168::2 soft-reconfiguration inbound | ||
exit-address-family | ||
! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
interface r1-eth0 | ||
ip address 192.0.2.1/24 | ||
! | ||
interface r1-eth1 | ||
ip address 192.168.0.1/24 | ||
ipv6 address 192:168::1/64 | ||
! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
router bgp 65502 | ||
bgp router-id 192.168.0.2 | ||
bgp log-neighbor-changes | ||
no bgp ebgp-requires-policy | ||
no bgp network import-check | ||
neighbor 192.168.0.1 remote-as 65501 | ||
neighbor 192:168::1 remote-as 65501 | ||
! | ||
address-family ipv4 unicast | ||
neighbor 192.168.0.1 activate | ||
no neighbor 192:168::1 activate | ||
redistribute connected | ||
exit-address-family | ||
! | ||
address-family ipv6 unicast | ||
neighbor 192:168::1 activate | ||
redistribute connected | ||
exit-address-family | ||
! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
interface r2-eth0 | ||
ip address 192.168.0.2/24 | ||
ipv6 address 192:168::2/64 | ||
! | ||
interface r2-eth1 | ||
ip address 172.31.0.2/24 | ||
ipv6 address 172:31::2/64 | ||
! |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this https://datatracker.ietf.org/doc/html/rfc7854#section-10.8 Peer Down type, is it defined somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added ref to https://datatracker.ietf.org/doc/rfc9069/ section 8.4