Nexthop group AFI calculation #17049
Open
+53
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small rework prepares next commit. Signed-off-by: Philippe Guibert <[email protected]>
A protocol nexthop group with multiple nexthop may have an undefined AFI value. > ubuntu2204hwe(config)# nexthop-group A > ubuntu2204hwe(config-nh-group)# nexthop 10.0.2.150 mgmt0 > ubuntu2204hwe(config-nh-group)# do show nexthop-group rib sharp > ID: 181818168 (sharp) > RefCnt: 1 > Uptime: 00:00:06 > VRF: default(IPv4) > Valid, Installed > Depends: (13) > via 10.0.2.150, mgmt0 (vrf default), weight 1 > ID: 13 (sharp) > RefCnt: 2 > Uptime: 00:00:06 > VRF: default(IPv4) > Valid, Installed > Interface Index: 2 > via 10.0.2.150, mgmt0 (vrf default), weight 1 > Dependents: (181818168) > ubuntu2204hwe(config-nh-group)# nexthop 10.0.2.155 mgmt0 > ubuntu2204hwe(config-nh-group)# do show nexthop-group rib sharp > ID: 181818168 (sharp) > RefCnt: 1 > Uptime: 00:00:02 > VRF: default(bad-value) <---- (AFI_UNSPEC) > Valid, Installed > Depends: (13) (14) > via 10.0.2.150, mgmt0 (vrf default), weight 1 > via 10.0.2.155, mgmt0 (vrf default), weight 1 > ID: 13 (sharp) > RefCnt: 2 > Uptime: 00:00:02 > VRF: default(IPv4) > Valid, Installed > Interface Index: 2 > via 10.0.2.150, mgmt0 (vrf default), weight 1 > Dependents: (181818168) > ID: 14 (sharp) > RefCnt: 2 > Uptime: 00:00:02 > VRF: default(IPv4) > Valid, Installed > Interface Index: 2 > via 10.0.2.155, mgmt0 (vrf default), weight 1 > Dependents: (181818168) On the creation of a nexthop-group, check the afi value for all the nexthops of that nexthop-group. Check that the value is the same, cancel the nexthop-group add otherwise. Signed-off-by: Mark Stapp <[email protected]> Signed-off-by: Philippe Guibert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let us set up the AFI calculation at ZAPI level.