bgpd: Process core when bgp instance is deleted

[kssoman]

• When the bgp is being deleted and routes are in clear workqueue
  and new aggregate address being allocated
• Added flag BGP_FLAG_DELETE_IN_PROGRESS in bgp structure to
  bgp instance is being deleted
• When adding aggregate route check this flag and peer_self is valid

Signed-off-by: Soman K S [email protected]

[louberger]

This may address part of the issue seen in #4479

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7996/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 4499, comparing to Git base SHA 6aba4ee

No Changes in Static Analysis warnings compared to base

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7996/artifact/shared/static_analysis/index.html

[kssoman]

The stack trace for the issue :

#0 0x00000350eac7d428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1 0x00000350eac7f02a in __GI_abort () at abort.c:89
#2 0x00000350eb999cca in core_handler (signo=11, siginfo=0x3ccf22691f0, context=0x3ccf22690c0) at lib/sigevent.c:249
#3
#4 info_make (type=type@entry=9, sub_type=sub_type@entry=2, instance=instance@entry=0, peer=0x0, attr=0x17aee4b540, rn=rn@entry=0x17b09e1e80) at bgp_route.c:2558
#5 0x00000017a270dd7e in bgp_aggregate_route (bgp=0x17a3ad9f10, p=, rinew=0x0, afi=AFI_IP6, safi=, del=, aggregate=0x17a64e7f10) at bgp_route.c:5307
#6 0x00000017a270eca0 in bgp_aggregate_decrement (bgp=0x17a3ad9f10, p=p@entry=0x17ae176570, del=del@entry=0x17ae3f7e80, afi=AFI_IP6, safi=SAFI_UNICAST) at bgp_route.c:5396
#7 0x00000017a270edae in bgp_aggregate_decrement (safi=SAFI_UNICAST, afi=AFI_IP6, del=0x17ae3f7e80, p=0x17ae176570, bgp=) at bgp_route.c:2490
#8 bgp_rib_remove (rn=0x17ae176570, ri=0x17ae3f7e80, peer=0x17a38b0b60, afi=AFI_IP6, safi=SAFI_UNICAST) at bgp_route.c:2485
#9 0x00000017a270ee41 in bgp_clear_route_node (wq=, data=) at bgp_route.c:3548
#10 0x00000350eb9ac9dc in work_queue_run (thread=0x3ccf226a170) at lib/workqueue.c:282
#11 0x00000350eb9a6360 in thread_call (thread=thread@entry=0x3ccf226a170) at lib/thread.c:1498
#12 0x00000350eb984278 in frr_run (master=0x17a3208540) at lib/libfrr.c:879
#13 0x00000017a26e3c9d in main (argc=6, argv=0x3ccf226a3c8) at bgp_main.c:420

The configuration used aggregate-address command

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4499 9f822fa
Date	06/12/2019
Start	14:04:55
Finish	14:27:07
Run-Time	22:12
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-06-12-14:04:55.txt
Log	autoscript-2019-06-12-14:05:57.log.bz2
Memory	428 420 360

For details, please contact louberger