[7.4] lib: fix route map description memory leak

[rzalamena]

Summary

Backport of #6681 .

Route map entries are not getting a chance to call description string
deallocation on shutdown or when the parent entry is destroyed, so lets
add a code to handle this in the route_map_index_delete function.

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/6683 cc45875
Date	07/06/2020
Start	16:15:17
Finish	16:41:13
Run-Time	25:56
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-06-16:15:17.txt
Log	autoscript-2020-07-06-16:16:16.log.bz2
Memory	499 497 426

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu 18.04 arm7 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 arm7 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/U18ARM7BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Debian 9 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 20.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 20.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/U2004AMD64BUILD/ErrorLog/log_lintian.txt)

W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 18.04 ppc64le build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/U1804PPC64LEBUILD/ErrorLog/log_lintian.txt)

W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 16.04 i386 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 16.04 arm8 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 arm8 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/U16ARM8BUILD/ErrorLog/log_lintian.txt)

W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 18.04 arm8 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 arm8 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/U18ARM8BUILD/ErrorLog/log_lintian.txt)

W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 16.04 arm7 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 arm7 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/CI101BUILD/ErrorLog/log_lintian.txt)

W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Debian 8 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: changelog-file-missing-explicit-entry 7.4-0 -> 7.4-20200706-01-gcc45875e0-0 (missing) -> 7.4-20200706-01-gcc45875e0-0~deb10u1
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: changelog-file-missing-explicit-entry 7.4-0 -> 7.4-20200706-01-gcc45875e0-0 (missing) -> 7.4-20200706-01-gcc45875e0-0~deb10u1
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: changelog-file-missing-explicit-entry 7.4-0 -> 7.4-20200706-01-gcc45875e0-0 (missing) -> 7.4-20200706-01-gcc45875e0-0~deb10u1
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.4-0 -> 7.4-20200706-01-gcc45875e0-0 (missing) -> 7.4-20200706-01-gcc45875e0-0~deb10u1
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: changelog-file-missing-explicit-entry 7.4-0 -> 7.4-20200706-01-gcc45875e0-0 (missing) -> 7.4-20200706-01-gcc45875e0-0~deb10u1

Ubuntu 16.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 18.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12976/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"