Do not incorrectly include orderBy as values in delete statements

orderBy is rendered in AdvancedStatement::renderOrderBy without placeholders
FaaPz · Jan 22, 2023 · 8f122ba · 8f122ba
1 parent 891d066
commit 8f122ba
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/Statement/Delete.php b/src/Statement/Delete.php
@@ -77,10 +77,6 @@ public function getValues(): array
             $values = array_merge($values, $this->where->getValues());
         }
 
-        if (!empty($this->orderBy)) {
-            $values = array_merge($values, $this->orderBy);
-        }
-
         if ($this->limit != null) {
             $values = array_merge($values, $this->limit->getValues());
         }

diff --git a/tests/Statement/DeleteTest.php b/tests/Statement/DeleteTest.php
@@ -162,9 +162,8 @@ public function testGetValuesWithOrderBy()
             ->orderBy('id', 'ASC')
             ->orderBy('name', 'DESC');
 
-        // FIXME This seems broken...
         $this->assertIsArray($this->subject->getValues());
-        $this->assertCount(2, $this->subject->getValues());
+        $this->assertCount(0, $this->subject->getValues());
     }
 
     public function testGetValuesWithLimit()