Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some value tracking mistakes #177

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from
Open

Fix some value tracking mistakes #177

wants to merge 4 commits into from

Commits on Jan 23, 2023

  1. Fix value-tracking for Conditionals with multi-value subqueries

    @bnf
    bnf committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    574faaf View commit details
    Browse the repository at this point in the history

  2. Fix value-tracking for JOIN's with subselects

    @bnf
    bnf committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    0bac3cb View commit details
    Browse the repository at this point in the history

  3. Do not incorrectly include orderBy as values in delete statements 

    orderBy is rendered in AdvancedStatement::renderOrderBy without placeholders
    @bnf
    bnf committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    2a4a1fd View commit details
    Browse the repository at this point in the history

  4. Remove FIXME in UpdateTest 

    one Value is fine as orderBy doesn't use values at all.
    @bnf
    bnf committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    f838058 View commit details
    Browse the repository at this point in the history