Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Guides #26

Merged
merged 10 commits into from
Feb 10, 2024
Merged

Command Guides #26

merged 10 commits into from
Feb 10, 2024

Conversation

dicedpixels
Copy link
Contributor

@dicedpixels dicedpixels commented Jan 24, 2024

Ports the main "Commands" page from the Wiki. There 5 more pages supplementing this one. I will port them later.
There are no major changes other than removing any reference to static imports (which seemed to confuse people a lot). Client commands are in their own section.
I also excluded the large block of method calls under "What can the ServerCommandSource do?" since it felt unnecessary. I'm open to adding this if there's a different opinion.
Code is directly pulled from the reference mod except the lambda in line 44.


IMB11: We've decided to port all the pages in 1 PR.

  • Creating Commands
  • Command Arguments
  • Command Suggestions (in progress)
  • Command Redirects
  • Dynamic Commands Seperate PR.

@dicedpixels dicedpixels requested a review from a team as a code owner January 24, 2024 14:42
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 0d19b11
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/65c717a70768540008450d34
😎 Deploy Preview https://deploy-preview-26--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@IMB11 IMB11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could potentially be split up into three pages:

  • Introduction To Commands (What you have so far, brief touch on basic arguments)
  • Dynamic Commands (mentioned in the FAQ, this could be expanded upon as there's quite a few use cases for it)
  • Command Arguments (custom command argument types, how to make command arguments that work without mod on client side too - spoofing types)

develop/commands/creating-commands.md Outdated Show resolved Hide resolved
develop/commands/creating-commands.md Outdated Show resolved Hide resolved
develop/commands/creating-commands.md Outdated Show resolved Hide resolved
develop/commands/creating-commands.md Outdated Show resolved Hide resolved
develop/commands/creating-commands.md Outdated Show resolved Hide resolved
develop/commands/creating-commands.md Outdated Show resolved Hide resolved
@IMB11 IMB11 added new-content A new page or set of pages stage:expansion This should be expanded stage:cleanup This should be cleaned up and removed stage:expansion This should be expanded labels Jan 24, 2024
@dicedpixels
Copy link
Contributor Author

Looks good, but could potentially be split up into three pages:

  • Introduction To Commands (What you have so far, brief touch on basic arguments)
  • Dynamic Commands (mentioned in the FAQ, this could be expanded upon as there's quite a few use cases for it)
  • Command Arguments (custom command argument types, how to make command arguments that work without mod on client side too - spoofing types)

Sure! As a start, I will move the rest of the command related pages here. We'll reorganize and add new pages after that.

@IMB11 IMB11 changed the title Commands Guide #1 Commands Guides Jan 24, 2024
@IMB11 IMB11 removed the stage:cleanup This should be cleaned up label Jan 24, 2024
@IMB11 IMB11 marked this pull request as draft January 24, 2024 18:43
@IMB11 IMB11 changed the title Commands Guides Command Guides Jan 24, 2024
@IMB11 IMB11 self-assigned this Jan 24, 2024
@IMB11 IMB11 mentioned this pull request Jan 25, 2024
19 tasks
@IMB11 IMB11 marked this pull request as ready for review February 4, 2024 18:02
IMB11
IMB11 previously approved these changes Feb 4, 2024
@IMB11 IMB11 requested a review from a team February 9, 2024 18:37
@IMB11 IMB11 added the stage:cleanup This should be cleaned up label Feb 9, 2024
modmuss50
modmuss50 previously approved these changes Feb 9, 2024
@dicedpixels dicedpixels dismissed stale reviews from modmuss50 and IMB11 via 0d19b11 February 10, 2024 06:28
@IMB11 IMB11 merged commit 6cd45d8 into FabricMC:main Feb 10, 2024
6 checks passed
@its-miroma its-miroma added stage:ready This is ready to be merged and removed stage:cleanup This should be cleaned up labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-content A new page or set of pages stage:ready This is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants