Add loader-style smever format MC versions #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
requested changes
Mar 15, 2021
src/main/java/net/fabricmc/meta/utils/MinecraftSemverConverter.java
Outdated
Show resolved
Hide resolved
|
The docs (readme) need updating as well. |
modmuss50
requested changes
Mar 15, 2021
|
|
||
| public static class Meta { | ||
|
|
||
| String assets; |
There was a problem hiding this comment.
Im not sure the asset id always matches the target.
There was a problem hiding this comment.
I haven't seen a case where it hasn't.
Here's the output it generates: https://gist.github.com/dexman545/4ad16ef4e1de9d10f9042b54fc5fd8ab
src/main/java/net/fabricmc/meta/utils/MinecraftLauncherMeta.java
Outdated
Show resolved
Hide resolved
src/main/java/net/fabricmc/meta/utils/MinecraftLauncherMeta.java
Outdated
Show resolved
Hide resolved
|
20w30a seems wrong (without checking) should be 1.16.2 |
Replace stream with for-loop refactor getMajorVersion -> getTargetVersion
It is, will look into it |
|
Talked briefly about in discord; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
semverentry tov2/versions/gameand create av2/versions/game/:game_versionendpoint.Allows external tools to convert an MC version* to something semver compliant for parsing.
Useful for tools such as
modmuss.me/fabric.htmlto include an entry for use infabric.mod.jsonas it is not always immediately obvious how loader will translate the version for enforcement.