Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add armor texture provider hook #99

Closed
wants to merge 1 commit into from

Conversation

asiekierka
Copy link
Contributor

TODO:

  • Better interface name?
  • Is capturing ItemStack here useful for modders? Do modders realistically vary their armor textures by NBT at any point, often enough to not justify mixing deeper into ArmorFeatureRenderer with a custom renderer? Would simplify the patch not to.

@LemmaEOF
Copy link

NamespacedArmorItem fits the guidelines more, since Namespaced is an adjective. I can also see an advantage to NBT for anything dyeable.

@asiekierka
Copy link
Contributor Author

asiekierka commented Feb 21, 2019

No, that's the texture. Dyes are handled separately.

Besides, as tradition, I would expect a more complex armor renderer to just inject into renderArmor's HEAD and redirect processing entirely.

@LemmaEOF
Copy link

Ah, right, that was just changed. I can see advantages to having NBT access for stuff like IC2's jetpack duct tape, but since that's supposed to be for any armor that'd be better done as a mixin.

@asiekierka
Copy link
Contributor Author

From discussion on IRC:

  • This hook may be best left to just ArmorItem,
  • because Mojang generally implements custom renderers via appending them in .addFeature(). For this, an event should be provided (no performance issue - runs only on instantiation).

@asiekierka
Copy link
Contributor Author

Time to make a new PR.

@asiekierka asiekierka closed this May 11, 2019
BoogieMonster1O1 added a commit to BoogieMonster1O1/fabric that referenced this pull request May 27, 2022
* Add stuff

* Fix imports

* it builds now

* Move the testmod

* permisisons api api?
BoogieMonster1O1 pushed a commit to BoogieMonster1O1/fabric that referenced this pull request May 27, 2022
BoogieMonster1O1 added a commit to BoogieMonster1O1/fabric that referenced this pull request May 27, 2022
* Revert "Revert "Command API (v2) and Permissions API skeleton (FabricMC#99)" (FabricMC#101)"

This reverts commit a144b87.

* Update buildscript and deprecate permissions

* Use jetbrains annotations

* Checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants