Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user be less dependent on his FS layout #222

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

seregasheypak
Copy link

@chen-factual
Copy link
Contributor

@dirtyvagabond do you know why this was here? I'm looking in /usr/include/linux/limits.h and PATH_MAX is defined as 4096. I did some Googling and the only reasonable explanation I could turn up was Windows has a 260 char limit, in which case we should greatly increase this limit.

@dirtyvagabond
Copy link
Contributor

@chen-factual @seregasheypak my best guess is what Chen says, we were worried about Windows (or some other OS that has a low number). i can imagine that if this breaks at runtime it could be confusing/irritating so it's nice to have the explicit safeguard.

would one of you be willing to make this config dynamic, based on some minimal logic that tries to confirm a friendly OS before providing the larger number? or some similar solution that doesn't blindly assume a larger max?

@chen-factual
Copy link
Contributor

@seregasheypak since you've already got the PR, would you like to take this on? You can use something like Apache SystemUtils (stack overflow thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants