-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slurm plug-in: remove --cpus-per-task requirement #442
Comments
dds-submit-slurm: Modified: Remove #SBATCH --ntasks-per-node=1. (FairRootGroupGH-444) dds-submit-slurm: Modified: Remove #SBATCH --cpus-per-task=%DDS_NSLOTS%. (FairRootGroupGH-442)
Would it be reasonable to configure dds::tools_api::SSubmitRequest::request_t requestInfo;
requestInfo.m_cores = 10; ? |
@rbx , this is the plan. I don’t want to give up on this protection. |
dds-submit: Added: The command learned a new argument --enable-overbooking. The flag instructs DDS RMS plug-ing to not specify any CPU requirement for RMS jobs. (FairRootGroupGH-442) dds-tools-api: Added: SSubmitRequestData supports flags. See SSubmitRequestData::setFlag and SSubmitRequestData::ESubmitRequestFlags. (FairRootGroupGH-442) dds-slurm-plugin: Modified: The #SBATCH --cpus-per-task=%DDS_NSLOTS% requirment is now can be disiabled by providing the "enable-overbooking" flag (ToolsAPI or dds-submit). (FairRootGroupGH-442)
dds-submit: Added: The command learned a new argument --enable-overbooking. The flag instructs DDS RMS plug-ing to not specify any CPU requirement for RMS jobs. (FairRootGroupGH-442) dds-tools-api: Added: SSubmitRequestData supports flags. See SSubmitRequestData::setFlag and SSubmitRequestData::ESubmitRequestFlags. (FairRootGroupGH-442) dds-slurm-plugin: Modified: The #SBATCH --cpus-per-task=%DDS_NSLOTS% requirment is now can be disiabled by providing the "enable-overbooking" flag (ToolsAPI or dds-submit). (FairRootGroupGH-442)
dds-submit: Added: The command learned a new argument --enable-overbooking. The flag instructs DDS RMS plug-ing to not specify any CPU requirement for RMS jobs. (GH-442) dds-tools-api: Added: SSubmitRequestData supports flags. See SSubmitRequestData::setFlag and SSubmitRequestData::ESubmitRequestFlags. (GH-442) dds-slurm-plugin: Modified: The #SBATCH --cpus-per-task=%DDS_NSLOTS% requirment is now can be disiabled by providing the "enable-overbooking" flag (ToolsAPI or dds-submit). (GH-442)
@rbx , the feature is implemented in the master.
Please note, by default the flag is off. That means ODC needs to enable it for ALL alice partitions, except the ones which need a CPU-based allocation. |
DDS slurm plug-in sets the --cpus-per-task= to the number of task slots per agent.
That was intently made to prevent users from overbooking resources on slurm.
Looks like this is not always convenient, according to ALICE pre-production tests.
This requirement should be either configurable (enabled by an option in dds submit) or completely removed.
I lean to the configurable solution.
dds-submit and its ToolsAPI should accept an "--enable-overbooking" argument, which will instruct plug-in to disable --cpus-per-task (for slurm) and similar arguments in other RMS plug-ins. When specified, the responsibility to define cpu requirements will be delegated to the user.
The text was updated successfully, but these errors were encountered: