Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RuleSetProvider necessary to get rules executed #4

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

travisMiehm
Copy link
Collaborator

No description provided.

UseSetInsteadOfListToSet(config),
)
)
}
Copy link
Collaborator

@Nava2 Nava2 Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 we should probably install detekt to run in this repo

Copy link
Collaborator Author

@travisMiehm travisMiehm Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO() 😢

Comment on lines +33 to +34
ruleSetId,
listOf(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arg names

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think they're necessary here. The two arguments are pretty clear.

@travisMiehm travisMiehm enabled auto-merge (squash) December 14, 2023 14:53
@travisMiehm travisMiehm merged commit f969822 into main Dec 14, 2023
3 checks passed
@travisMiehm travisMiehm deleted the travis/add-rulesetprovider branch December 14, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants