Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add paperwork #1

Merged
merged 5 commits into from
Jul 15, 2020
Merged

add paperwork #1

merged 5 commits into from
Jul 15, 2020

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Jul 6, 2020

No description provided.

Copy link
Contributor

@makoscafee makoscafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. had few comments.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@makoscafee
Copy link
Contributor

makoscafee commented Jul 6, 2020

ooh before it get merged ... mind adding also all the command options like output-file, helm_version in the ReadMe etc.

@rbren rbren merged commit ed2e90c into master Jul 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the rb/paperwork branch July 15, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants