Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc/rd 71 add plg links #186

Merged
merged 6 commits into from
Jan 4, 2023
Merged

Sc/rd 71 add plg links #186

merged 6 commits into from
Jan 4, 2023

Conversation

transient1
Copy link
Contributor

This PR fixes #

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

Add link to Insights free tier

What changes did you make?

Added persistentpostrun to int in root.go

What alternative solution should we consider, if any?

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2022

CLA assistant check
All committers have signed the CLA.

@fairwinds-insights
Copy link

Fairwinds Insights CI Report

View the Full Report

✅ No new Action Items detected!

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am realizing that this still runs when you do nova version. I wonder if that's desirable?

@transient1
Copy link
Contributor Author

@sudermanjr Addressed the version output concern.

@transient1
Copy link
Contributor Author

@rbren or @bbensky
Can one of you approve this if it's okay?

@sudermanjr sudermanjr enabled auto-merge (squash) January 4, 2023 20:40
@sudermanjr sudermanjr merged commit baccd91 into master Jan 4, 2023
@sudermanjr sudermanjr deleted the sc/RD-71-add-PLG-links branch January 4, 2023 20:40
@fairwinds-insights
Copy link

Fairwinds Insights - Auto-scan job has failed ❌

View the Full Report

Show Logs
found 1 pods for job repo-scan-job-17255
logs for pod repo-scan-job-17255-nx4sv:
time="2023-01-04T20:40:39Z" level=info msg="cloneRepo: true"
time="2023-01-04T20:40:39Z" level=info msg="cloning github repository"
time="2023-01-04T20:40:39Z" level=error msg="Error running /usr/bin/git clone --branch sc/RD-71-add-PLG-links https://x-access-token:<TOKEN>@github.com/FairwindsOps/nova - Cloning into 'nova'...\nfatal: Remote branch sc/RD-71-add-PLG-links not found in upstream origin\n[exit status 128]"
time="2023-01-04T20:40:39Z" level=fatal msg="Error creating CI Scan main struct: could not get configuration: unable to clone repository: exit status 128"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants