Use new ArtifactHub cached API #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fairwinds Insights CI Report✅ No new Action Items detected! |
tegioz
reviewed
May 9, 2023
pkg/helm/artifacthub_cached.go
Outdated
| r.Header.Add("accept", "application/json") | ||
| r.Header.Set("User-Agent", ac.UserAgent) | ||
| var response *http.Response | ||
| for attempt := 1; attempt <= 5; attempt++ { |
There was a problem hiding this comment.
It'd be great if you could use some sort of exponential backoff (like https://github.com/cenkalti/backoff) or introduce a pause instead of retrying immediately a few times when something goes wrong. In some situations (like when encountering rate limit errors), this may make things even worse.
There was a problem hiding this comment.
Good catch! I removed the retry logic entirely. I think it's an artifact from when we originally queried the repositories themselves, which were very flaky
rbren
changed the title
transient1
approved these changes
May 9, 2023
bbensky
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues w/ ArtifactHub rate limiting by using the new cache API AH is providing for Nova
Checklist
Description
What's the goal of this PR?
Move to the new cached API
What changes did you make?
Added and utilized a new "cached client"
I also removed some unused fields from the old struct, to help ensure that we're getting all the data we really need
What alternative solution should we consider, if any?