Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change output format, use tabwriter #3

Merged
merged 8 commits into from
Jul 24, 2020
Merged

Change output format, use tabwriter #3

merged 8 commits into from
Jul 24, 2020

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Jul 15, 2020

This cleans up the output a bit in anticipation of an OSS release

Copy link
Contributor

@makoscafee makoscafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. had few comments

ReleaseName: "foo",
Namespace: "foo",
Installed: VersionInfo{
Version: "1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this also include AppVersion just incase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

return fmt.Sprintf(txt, output.Version, output.NewestVersion, *output.AppVersion, *output.NewestAppVersion)
}
return ""
type VersionInfo struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot comment here

@rbren rbren merged commit 810a0ef into master Jul 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the rb/output branch July 24, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants