-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change output format, use tabwriter #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.. had few comments
pkg/output/file_test.go
Outdated
ReleaseName: "foo", | ||
Namespace: "foo", | ||
Installed: VersionInfo{ | ||
Version: "1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this also include AppVersion
just incase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
return fmt.Sprintf(txt, output.Version, output.NewestVersion, *output.AppVersion, *output.NewestAppVersion) | ||
} | ||
return "" | ||
type VersionInfo struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot comment here
This cleans up the output a bit in anticipation of an OSS release