INSIGHTS-159 - use go templating instead of custom function validation (

#1056)

* use go templating instead of custom function validation

* fix changelog

docs/changelog.md

@@ -6,6 +6,9 @@ meta:
 
 ---
 
+## unreleased
+* Rewrite `hpaMaxAvailability` check to use go-template
+
 ## 9.1.0
 * Add HPA `minAvailable` and HPA `maxAvailable` checks 
 * Fix typo for PDB `minAvailable`

pkg/config/checks/hpaMaxAvailability.yaml

@@ -1,4 +1,35 @@
 successMessage: HPA has a valid max and min replica configuration
 failureMessage: HPA maxReplicas and minReplicas should be different 
 category: Reliability
-target: autoscaling/HorizontalPodAutoscaler
+target: autoscaling/HorizontalPodAutoscaler
+schemaString: |
+  "$schema": http://json-schema.org/draft-07/schema#
+  type: object
+  properties:
+    spec:
+      type: object
+      properties:
+        minReplicas:
+          type: integer
+          minimum: 1
+        maxReplicas:
+          type: integer
+          minimum: 1
+      required:
+      - maxReplicas
+      {{- if .spec.minReplicas }}
+      if:
+        properties:
+          minReplicas:
+            type: integer
+          maxReplicas:
+            type: integer
+      then:
+        properties:
+          maxReplicas:
+            exclusiveMinimum: {{ .spec.minReplicas }}
+      else:
+        properties:
+          maxReplicas:
+            minimum: 1
+      {{- end }}

pkg/validator/schema.go

@@ -369,8 +369,6 @@ func applySchemaCheck(conf *config.Configuration, checkID string, test schemaTes
 		passes, issues, err = check.CheckContainer(test.Container)
 	} else if check.Validator.SchemaURI != "" {
 		passes, issues, err = check.CheckObject(test.Resource.Resource.Object)
-	} else if customValidators[checkID] != nil {
-		passes, issues, err = customValidators[checkID](test.Resource.Resource.Object)
 	} else {
 		passes, issues, err = true, []jsonschema.ValError{}, nil
 	}