jg/json endpoint #11
jg/json endpoint #11
Conversation
pkg/kube/clientset.go
Outdated
|
|
||
| var clientset = createClientset() | ||
|
|
||
| // Kubernetes version 1.11 APIs |
There was a problem hiding this comment.
Why specify the specific API version here?
There was a problem hiding this comment.
yeah i don't really need to, let me remove that
pkg/kube/clientset.go
Outdated
| return clientset | ||
| } | ||
|
|
||
| func getKubeConfig() string { |
There was a problem hiding this comment.
controller-runtime's config.getConfigOrDie() function should probably suffice here, and is already in use. Ideally that would also mean there was no need to add an additional package. https://github.com/reactiveops/fairwinds/blob/master/main.go#L55
| image: quay.io/reactiveops/fairwinds | ||
| command: ["fairwinds", "--webhook"] |
There was a problem hiding this comment.
Is it valid just to run a single container with both --webhook and --dashboard flags? Both ports could be specified in the container spec.
There was a problem hiding this comment.
yeah i can do that, will just need to make a start up script or use a process manager, but that seems easy enough.
|
|
||
| func validateHandler(w http.ResponseWriter, r *http.Request, c conf.Configuration) { | ||
| var results []validator.Results | ||
| pods, err := kube.CoreV1API.Pods("").List(metav1.ListOptions{}) |
There was a problem hiding this comment.
At some point in the future it would be really nice to group/validate these results by deployment/daemon set/stateful set/etc to simplify the validation and output.
There was a problem hiding this comment.
yeah def, i think the next step will be to validate deployments vs pods.
This is the first pass at adding a json endpoint to return results of validating existing pods in the cluster. There will need to be refactoring (and tests), but I want to make sure this is in alignment with what we want before I make more changes. This works and is currently deployed to the cluster.
This PR does the following: