Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jg/add deploys #12

Merged
merged 6 commits into from
Jan 28, 2019
Merged

jg/add deploys #12

merged 6 commits into from
Jan 28, 2019

Conversation

JessicaGreben
Copy link
Contributor

This PR does the following:

  • creates a validation admission webhook for deployments
  • the json endpoint for the dashboard now validates deployments instead of pods

robscott
robscott approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JessicaGreben JessicaGreben merged commit af858e8 into master Jan 28, 2019
@JessicaGreben JessicaGreben deleted the jg/add-deploys branch January 28, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JessicaGreben @robscott