add output-file flag #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
force-pushed
the
rb/output-file-flag
branch
from
0392bfe
to
38ddba2
Compare
robscott
suggested changes
Apr 18, 2019
main.go
Outdated
|
|
||
| client := &http.Client{} | ||
| resp, err := client.Do(req) | ||
| fmt.Println(string(y)) |
There was a problem hiding this comment.
I think a call to os.Stdout.Write could be better here. https://godoc.org/os#File.Write
main.go
Outdated
| } | ||
| defer resp.Body.Close() | ||
|
|
||
| body, _ := ioutil.ReadAll(resp.Body) |
There was a problem hiding this comment.
We should likely not ignore the potential error in the response from ioutil.ReadAll (https://golang.org/pkg/io/ioutil/#ReadAll)
There was a problem hiding this comment.
That's what I get for copy/pasting from Stack Overflow
| k, _ := kube.CreateKubeAPI() | ||
| auditData, err := validator.RunAudit(c, k) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| if destination != "" { | ||
| jsonData, err := json.Marshal(auditData) | ||
| if outputURL == "" && outputFile == "" { |
There was a problem hiding this comment.
Could this whole section be restructured to something like:
if outputURL != "" {
# send to url
} else if outputFile != "" {
# send to file
} else {
# send to stdout
}
There was a problem hiding this comment.
That's I originally had it, but
- There's some common logic for
outputURLandoutputFilefor serializing to JSON - We need to output to both file and URL in some cases (e.g. the hosted version needs this)
There was a problem hiding this comment.
👍 that makes a lot of sense
robscott
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.