-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prep for 4.2.0 release and helm chart update #643
Conversation
@@ -15,12 +15,12 @@ | |||
package main | |||
|
|||
import ( | |||
"github.com/fairwindsops/polaris/cmd/polaris" | |||
cmd "github.com/fairwindsops/polaris/cmd/polaris" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My editor kept wanting to change this so even though the module at that directory is named cmd
this makes the below code more clear I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -15,12 +15,12 @@ | |||
package main | |||
|
|||
import ( | |||
"github.com/fairwindsops/polaris/cmd/polaris" | |||
cmd "github.com/fairwindsops/polaris/cmd/polaris" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh - README.md needs the new version too
Also if you wouldn't mind updating docs/changelog.md |
No description provided.