add badges #78
Merged
add badges #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
force-pushed
the
rb/add-badges
branch
2 times, most recently
from
83e32ce
to
4dba266
Compare
robscott
reviewed
May 14, 2019
There was a problem hiding this comment.
Is this requiring us to update a test coverage badge with every commit? Is there a way to push coverage info to some kind of third party service like https://coveralls.io/ that could be integrated into CI and automated away?
|
Yeah this would require re-running the coverage script with every push. I like the idea of using coveralls. Hard for me to evaluate right now since the project is private, but we can investigate once it's public. For now, I can ditch the CircleCI check, or just remove the badge. |
|
I think I'd remove the badge if it's going to require manual intervention from us, and then as soon as it's open sourced, we can experiment with coveralls or something. |
|
Sounds good, done |
robscott
approved these changes
May 15, 2019
add go report, coverage fix coverage link Update README.md Update README.md Update README.md fix badge colors Update README.md Update README.md add coverage to circleci better coverage calculation fix circleci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.