Improving error handling #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
reviewed
May 16, 2019
| return err | ||
| } | ||
| specs := regexp.MustCompile("\n-+\n").Split(string(contents), -1) | ||
| for _, spec := range specs { | ||
| err = addYaml(spec) | ||
| if err != nil { | ||
| logrus.Errorf("Error parsing YAML %v", err) |
There was a problem hiding this comment.
FYI this error will be logged twice (once in addYaml), but maybe for the best
There was a problem hiding this comment.
Yeah, that was intentional. I wanted to have more specific logging in addYaml but also add this as a failsafe if an error hadn't already gotten logged there. It will likely be repetitive if they run into an error, but does ensure we catch things added to addYaml in the future that may not get the same kind of logging in the future. I don't know, that could be overkill.
rbren
reviewed
May 16, 2019
| @@ -89,10 +89,18 @@ func main() { | |||
| if *webhook { | |||
| startWebhookServer(c, *disableWebhookConfigInstaller, *webhookPort) | |||
| } else if *dashboard { | |||
| k, _ := kube.CreateResourceProvider(*auditPath) | |||
| k, err := kube.CreateResourceProvider(*auditPath) | |||
There was a problem hiding this comment.
These will get logged twice as well.
rbren
approved these changes
May 16, 2019
robscott
force-pushed
the
rs/better-error-handling
branch
from
d959109
to
40bb07b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of places where errors were not being logged or displayed, this should fix a bunch of them.