Add option to filter audit results by severity level #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fairwinds Insights CI Report✅ No new Action Items detected! |
1 similar comment
Fairwinds Insights CI Report✅ No new Action Items detected! |
jslivka
force-pushed
the
jbs/severity-level-filter
branch
from
dda78ff
to
20b7d48
Compare
rbren
approved these changes
Jun 27, 2023
Comment on lines
+60
to
+71
| resCopy := res | ||
| resCopy.Results = []Result{} | ||
|
|
||
| filteredResults := funk.Map(res.Results, func(auditDataResult Result) Result { | ||
| return auditDataResult.filterResultsBySeverityLevel(severityLevel) | ||
| }).([]Result) | ||
|
|
||
| for _, result := range filteredResults { | ||
| if result.isNotEmpty() { | ||
| resCopy.Results = append(resCopy.Results, result) | ||
| } | ||
| } |
There was a problem hiding this comment.
Man 😓 the structure of the polaris output makes this harder than it should be.
Probably not for this PR, but if we wanted to do other kinds of filtering we could probably create a generic AuditData.filter method that takes in a func(Result) bool, so we only have to define the weird "drill into each result" logic in one place.
There was a problem hiding this comment.
Yes that would be great, have some sort of filter function that takes a predicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #
Checklist
Description
To address #754, I've chosen to implement verbosity options for displaying audit results in the same manner as log levels.
dangeris the least verbose option and will only include results of that severity.warningis the medium verbosity option and will only display results of severitywarningordanger. By default, all results will be displayed. This will still function with--only-show-failed-testsand behave as expected.What's the goal of this PR?
Add verbosity options to the
auditsubcommand in the polaris CLIWhat changes did you make?
Low verbosity (
danger)Medium verbosity (
warning, also implies inclusion ofdanger)What alternative solution should we consider, if any?