Skip to content

Commit

Permalink
Apply review changes
Browse files Browse the repository at this point in the history
Remove superfluous tests
  • Loading branch information
LuisPH3 committed Oct 8, 2024
1 parent 0dd63cc commit 92403a8
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions go/interpreter/lfvm/memory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func TestMemory_getSlice_ErrorCases(t *testing.T) {
}
}

func TestMemory_getSlice_ReturnsSliceOfSize(t *testing.T) {
func TestMemory_getSlice_ReturnsSliceOfRequestedSize(t *testing.T) {

tests := map[string]struct {
offset *uint256.Int
Expand All @@ -238,7 +238,6 @@ func TestMemory_getSlice_ReturnsSliceOfSize(t *testing.T) {
size: uint256.NewInt(5),
expected: []byte{0x04, 4: 0x0},
},
// TODO: padding here or somewhere else?
}

for name, test := range tests {
Expand All @@ -250,9 +249,6 @@ func TestMemory_getSlice_ReturnsSliceOfSize(t *testing.T) {
if err != nil {
t.Errorf("unexpected error: %v", err)
}
if len(m.store) == 0 {
t.Errorf("expected memory to be expanded, but it is empty")
}
if !bytes.Equal(slice, test.expected) {
t.Errorf("unexpected slice: %x, want: %x", slice, test.expected)
}
Expand Down

0 comments on commit 92403a8

Please sign in to comment.