Split official LFVM configuration and experimental configurations #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerbertJordan
force-pushed
the
herbert/lfvm_split_production_and_experimental_configurations
branch
3 times, most recently
from
fd71787
to
628d32c
Compare
facuMH
previously approved these changes
Sep 13, 2024
HerbertJordan
force-pushed
the
herbert/lfvm_split_production_and_experimental_configurations
branch
from
628d32c
to
5eed6a2
Compare
HerbertJordan
requested review from
facuMH
and removed request for
simonlechner
HerbertJordan
force-pushed
the
herbert/lfvm_split_production_and_experimental_configurations
branch
from
0d2ed4e
to
20fb5a1
Compare
facuMH
approved these changes
Sep 16, 2024
LuisPH3
approved these changes
Sep 16, 2024
HerbertJordan
force-pushed
the
herbert/lfvm_split_production_and_experimental_configurations
branch
from
20fb5a1
to
b3bb90f
Compare
HerbertJordan
deleted the
herbert/lfvm_split_production_and_experimental_configurations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restricts the default registration of LFVM interpreter configurations to the
lfvmandlfvm-siconfigurations. These are the only configurations currently accessed outside Tosca. In a follow-up step, this set is to be further restricted to thelfvmoption only (once down-stream projects have been updated).Some changes contributed by this PR:
VMtype tolfvmto make the implementation package privateThis is part of #687 and #676