Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding state function to multiwalker #1149

Conversation

ffelten
Copy link
Contributor

@ffelten ffelten commented Dec 22, 2023

Description

I added a state method giving a global view of the env on multiwalker

Realtes to #323

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower
Copy link
Member

Awesome, have seen that issue up for a while thanks for the contribution Florian

Copy link
Member

@jjshoots jjshoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But yeah I would honestly put this into the base env since multiwalker.py's file structure basically mirrors other sisl environment's file structure, it's already calling self.env.x so moving it into the base env makes more sense too.

@ffelten
Copy link
Contributor Author

ffelten commented Dec 22, 2023

LGTM. But yeah I would honestly put this into the base env since multiwalker.py's file structure basically mirrors other sisl environment's file structure, it's already calling self.env.x so moving it into the base env makes more sense too.

@jjshoots done

@elliottower
Copy link
Member

Looks good to me as well, cheers (and happy holidays)

@elliottower elliottower merged commit 41d47d7 into Farama-Foundation:master Dec 23, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants