Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix and update translations #1040

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Nov 9, 2023

This PR updates and fixes the translations in Seamly2D & SeamlyMe.

Fixes:

  • Adds the qtbase ts files so that QT base widgets, such as standard buttons in dialogs are translated.
  • Adds the folder ../libs/vwidgets so that classes in this folder are translated.
  • Adds tooltip translations for the reset and savePreset buttons.
  • Adds true flag to UnitsToStr() in the dialogtool class so that the units suffix string is translated in the tool dialogs.
  • Adds translation to the "Toolbar" menu.
  • Adds translations to the Shortcut dialogs in Seamly2D and SeamlyMe
  • Correctly translates in the About dialogs "unknown" in the build revision if unknown.
  • Changes the FileDialog in SeamlyMe to DontUseNativeDialog.
  • Adds translations to the Utilities Calculator.
  • Now retranslates the UI if a userchanges the language while in SeamlyMe without having to restart SeamlyMe.
  • Removes unnecessary translations for qDebug() messages.
  • Now Clears status bar help message when slecting the Export tool in Draft or Piece mode.
  • Fixes a few QString related warnings. Such as helpLabel->setText("") should be helpLabel->setText(QString(""));
  • Adds Tabloid, AnsiC, AnsiD, AnsiE paper options.
  • Removes the min() / minimum() function translation in French. (issue BUG: function min() or minimum(); There seem to be two names for the same function, each half implemented #428)

Update:

  • Improve dialogs to adjust better to translated label text, where often other languages translate to longer text.

Update languages:

  • Spanish
  • German
  • Dutch

Add Languages:

  • British English

Fixes issue #428, Fixes issue #1036, Fixes issue #1037, Fixes issue #1038, Fixes issue #1039

@ghost
Copy link

ghost commented Nov 9, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@slspencer slspencer merged commit b4a0d3d into develop Nov 9, 2023
10 checks passed
@slspencer slspencer deleted the fix-and-update-translations branch November 9, 2023 23:16
@DSCaskey
Copy link
Contributor Author

DSCaskey commented Nov 9, 2023

Thank you Susan. I can now update my extensions feature from develop and get that pushed. I already know there's a few conflicts to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants