Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new filename extensions #1041

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

DSCaskey
Copy link
Contributor

This PR completes the rebranding by replacing the old file extensions with new ones, as well as new icons to go along with them.

Pattern files will now be saved as sm2d for Seamly2d files.

*.val → *.sm2d

Individual measurements will be saved as smis for SeamlyMe Individual Size files.

*.vit → *smis

Multisize measurements will be saved as smms for SeamlyMe Multi Size files.

*.vst → *smms

For comparison here’s the existing icons:

old_file_icons

and the new ones:
new_files_icons

The “orange” ME icon is for use in SeamlyMe for the “Open Template” actions. It will filter the path for *.vit, *.vst, *.smis, and *.smms.

new_me_toolbar

The Open individual and Open multisize file dialogs will filter for *.vit, *.smis and *.vst, *.smms repectively.

resolves issue #858

@ghost
Copy link

ghost commented Nov 12, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@csett86 csett86 linked an issue Nov 13, 2023 that may be closed by this pull request
@slspencer
Copy link
Collaborator

I have a question:
why 'SMIN' not 'SMME' ?

@DSCaskey
Copy link
Contributor Author

DSCaskey commented Nov 15, 2023 via email

@DSCaskey
Copy link
Contributor Author

I updated the individual size file icon to the SMIS version.

individual_size_512_file

@DSCaskey
Copy link
Contributor Author

DSCaskey commented Nov 15, 2023

Just providing a real example of code to help explain why for consistency, smis and smms make more sense than smme and smms:

//Use standard path to individual measurements
const QString dir = qApp->Seamly2DSettings()->getIndividualSizePath();

....

//Use standard path to multisize measurements
QString dir = qApp->Seamly2DSettings()->getMultisizePath();

it's not getMePath()... or worse getMeSizePath().

SMIS and SMMS identify the types the ME files are. SSME does not. Had the app been coded with just 1 measurement file extension, where the xml schema had a measurement type tag in it... that would be a different story. Then ssme would make sense, but it doesn't. Which is another one of those RT mysteries, as there is only one Measurements() class that can have a MeasurementsType::Multisize or MeasurementsType::Individual... so I see no reason for the 2 file types. But... can't change that at this point.

@slspencer slspencer merged commit 5e7cf9c into develop Nov 15, 2023
10 checks passed
@slspencer slspencer deleted the issue-858-new-filename-extensions branch November 15, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: new file extensions
2 participants