Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Maximum String value limit in 2.15 to 5 megs (from 1M in 2.15.0-rc1; unlimited before) #959

Closed
cowtowncoder opened this issue Mar 21, 2023 · 0 comments
Labels
performance Issue related to performance problems or enhancements

Comments

@cowtowncoder
Copy link
Member

As per concerns from some developers, I think I'd like to tune one of processing limits: that of maximum String value length. 2.15.0-rc1 imposed limit of 1_000_000 characters.
Since this is unlikely attack vector, but possibly something that affects certain binary data embedding (base64) use cases, I think we may want to start with higher limit.

I suggest 5 megs, to keep contiguous JVM heap usage at 10 megs.
This is very much an arbitrary limit; if anyone has ideas of better limit, please add comments.

Note: as an attack vector this seems like a low-risk one: attacker must provide all the data and cannot force pre-allocation (reads are done with incremental buffer allocation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Issue related to performance problems or enhancements
Projects
None yet
Development

No branches or pull requests

1 participant