Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce no default no-arg ctor found regression in XmlMapper. #10

Closed
wants to merge 1 commit into from

Conversation

vy
Copy link
Contributor

@vy vy commented Aug 27, 2021

Adds test to reproduce the no default no-arg ctor found regression introduced to XmlMapper in 2.12.0 and reported in FasterXML/jackson-dataformat-xml#491.

@henrik242
Copy link
Contributor

henrik242 commented Aug 31, 2021

lgtm 👍

(I have also tested that it passes in 2.11.x)

@vy
Copy link
Contributor Author

vy commented Aug 31, 2021

@cowtowncoder, mind assisting me to get this merged, please? If you need any changes, let me know.

@cowtowncoder
Copy link
Member

Forgot to ask: could this be moved to XML module itself? Is there need for it to be in integration tests?
The purpose of this test module is mostly to cover cross-module issues, but tests that fit in regular repos should usually go there.

@vy
Copy link
Contributor Author

vy commented Aug 31, 2021

🤦‍♂️ You are certainly right. Done. Closing this PR since it is superseded by FasterXML/jackson-dataformat-xml#492.

@vy vy closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants