-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix master branch build error around Deprecation Error #815
Conversation
@k163377 WDYT? I'd like you to verify this is the way to go as I don't know enough. CI passes so that makes sense. |
@@ -18,10 +18,8 @@ fun Class<*>.isKotlinClass(): Boolean = this.isAnnotationPresent(Metadata::class | |||
* map object. | |||
* @property nullIsSameAsDefault Default false. Whether to treat null values as absent when deserializing, thereby | |||
* using the default value provided in Kotlin. | |||
* @property singletonSupport Default: DISABLED. Mode for singleton handling. | |||
* @property enabledSingletonSupport Default: DISABLED. Mode for singleton handling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think default is either true
or false
, not enum, since we have:
val enabledSingletonSupport: Boolean = KotlinFeature.SingletonSupport.enabledByDefault,
It may be some error related to @JooHyukKim |
@cowtowncoder @k163377 Applied suggestions/fixes. Thanks! |
@cowtowncoder Good as far as I know but I think @k163377 has the final say here :) |
Thank you for the correction and sorry for the delay in checking. |
fixes #813